FrankChen021 commented on code in PR #20621:
URL: https://github.com/apache/druid/pull/20621#discussion_r4306042843
##########
web-console/src/editor-completions/sql-completions.ts:
##########
@@ -100,6 +104,9 @@ const SQL_KEYWORD_FOLLOW_SUGGESTIONS: Record<string,
string[]> = {
GROUPING: ['SETS'],
FETCH: ['FIRST', 'NEXT'],
FIRST: ['ROW', 'ROWS'],
+ ASC: ['NULLS'],
+ DESC: ['NULLS'],
+ NULLS: ['FIRST', 'LAST'],
Review Comment:
Verified at head `4b9cfbd5797b017f9a73e2e13781886c3ee42684`; the P2 is
fixed. Reviewed 16 of 16 changed files and found no remaining actionable issues.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
