leventov commented on a change in pull request #7293: AggregatorFactory: Clarify methods that return other AggregatorFactories. URL: https://github.com/apache/incubator-druid/pull/7293#discussion_r268347203
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java ########## @@ -120,9 +144,15 @@ public AggregatorFactory getMergingFactory(AggregatorFactory other) throws Aggre } /** - * Gets a list of all columns that this AggregatorFactory will scan + * Used by GroupByStrategyV1 when running nested groupBys, to "transfer" values from inner query results to an + * incremental index that the outer query will run on. This method is a bit goofy, and should probably not be used Review comment: Even after looking up "goofy" in a dictionary, I don't have a firm sense of what does this word mean. Maybe better to a less slang word. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
