vogievetsky commented on PR #20544: URL: https://github.com/apache/druid/pull/20544#issuecomment-6272407172
@FrankChen021 re the `CollectAsyncResource` P1 from the latest review: this PR never touched `processing/`. #20504 landed on master after this branch's base, so comparing master's tip against the PR head made the fix look removed. I've merged master into the branch (5154498d23), so the diff no longer touches `processing/` and master's `CollectAsyncResource` is unchanged. The CodeQL resource-leak alert on `KafkaWebConsoleTest` was already handled in the current code: the `FileInputStream` is its own try-with-resources resource. With that, I believe all the review findings are resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
