amaechler commented on code in PR #20673: URL: https://github.com/apache/druid/pull/20673#discussion_r4350735684
########## licenses.yaml: ########## @@ -4326,25 +4326,26 @@ version: 2.2.0 libraries: - com.google.http-client: google-http-client - com.google.http-client: google-http-client-jackson2 + - com.google.http-client: google-http-client-apache-v2 + - com.google.http-client: google-http-client-gson --- -name: Google HTTP Client Library For Java +name: Google API Common license_category: binary module: java-core -license_name: Apache License version 2.0 -version: 1.45.2 +license_name: BSD-3-Clause License +version: 2.70.0 libraries: - - com.google.http-client: google-http-client-apache-v2 - - com.google.http-client: google-http-client-gson + - com.google.api: api-common Review Comment: I don’t think this applies. `api-common` does declare `javax.annotation-api`, but it reaches `lib/` through `google-auth-library-oauth2-http`, whose parent (`google-auth-library-parent 1.54.0`) manages `api-common` with an exclusion for `javax.annotation:javax.annotation-api`. So it’s never resolved into `lib/`. The built distribution has `lib/api-common-2.70.0.jar` but no `javax.annotation-api` in `lib/`, and the tree shows nothing under `api-common`: ```sh ./mvnw -q dependency:tree -pl services -Dincludes=com.google.api:api-common,javax.annotation -DoutputFile=/dev/stdout ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
