FrankChen021 commented on code in PR #20688:
URL: https://github.com/apache/druid/pull/20688#discussion_r4355554833


##########
processing/src/main/java/org/apache/druid/java/util/http/client/pool/ChannelResourceFactory.java:
##########
@@ -89,7 +90,7 @@ public ChannelFuture generate(final String hostname)
     log.debug("Generating: %s", hostname);
     URL url;
     try {
-      url = new URL(hostname);
+      url = URI.create(hostname).toURL();
     }
     catch (MalformedURLException e) {
       throw new RuntimeException(e);

Review Comment:
   add the forbidden rule when you migrate the usage in test cases as you plann



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to