drcrallen commented on a change in pull request #7273: Fix some IntelliJ
inspections
URL: https://github.com/apache/incubator-druid/pull/7273#discussion_r268842578
##########
File path:
extensions-contrib/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcHadoopInputRowParser.java
##########
@@ -246,15 +246,14 @@ static String typeStringFromParseSpec(ParseSpec
parseSpec)
builder.append(parseSpec.getTimestampSpec().getTimestampColumn()).append(":string");
// the typeString seems positionally dependent, so repeated timestamp
column causes incorrect mapping
if (parseSpec.getDimensionsSpec().getDimensionNames().size() > 0) {
- builder.append(",");
- builder.append(String.join(
Review comment:
If it is required for inspections to pass with the new rules then that is
the info that I was looking for. It wasn't clear to me how it was required here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
