FrankChen021 commented on code in PR #20706:
URL: https://github.com/apache/druid/pull/20706#discussion_r4367167294
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4066,17 +4072,15 @@ void maybeScaleDuringTaskRollover()
"Updating taskCount for supervisor[%s] from [%d] to [%d] during
rollover.",
supervisorId, currentTaskCount, rolloverTaskCount
);
- isScalingTasksOnRollover.set(true);
- try {
- new DynamicAllocationTasksNotice(
- () -> rolloverTaskCount,
- () -> {},
- emitter
- ).handle();
- }
- finally {
- isScalingTasksOnRollover.set(false);
- }
+ handleDynamicAllocationTasksNotice(
+ () -> rolloverTaskCount,
+ () -> {},
+ true
+ );
+ } else if (rolloverTaskCount != SupervisorTaskAutoScaler.CANNOT_COMPUTE)
{
Review Comment:
Thanks — I rechecked the current head. Because `LagBasedAutoScaler` inherits
`CANNOT_COMPUTE`, `maybeScaleDuringTaskRollover()` leaves
`dynamicTriggerLastScaleRunTime` unchanged, so regular lag-based scaling can
proceed once its existing cooldown elapses. The PR description scopes
rollover-only behavior to `costBased` and explicitly says `lagBased` is
unaffected, so I’m withdrawing the P2 for this PR. Lag-based rollover scaling
can be handled in the separate follow-up you mentioned.
Reviewed 4 of 7 changed files in this targeted follow-up.
<!-- mergelens:review -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
