FrankChen021 commented on code in PR #20737: URL: https://github.com/apache/druid/pull/20737#discussion_r4388811262
########## licenses.yaml: ########## @@ -1273,7 +1285,7 @@ name: io.swagger swagger-annotations license_category: binary module: extensions/druid-kubernetes-extensions license_name: Apache License version 2.0 -version: 2.8.6 +version: 2.14.0 Review Comment: [P2] Gson entry still uses the Swagger name **Finding:** The changed entry associates version 2.14.0 with com.google.code.gson:gson, but its name remains io.swagger swagger-annotations. generate-binary-license.py prints this name as the bundled component label, so the generated binary LICENSE will describe Gson 2.14.0 as Swagger 2.14.0. **Suggestion:** Rename the entry to a Gson-specific name, matching the other Gson entries, before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
