cryptoe opened a new pull request, #20753:
URL: https://github.com/apache/druid/pull/20753
### Description
The pre-push hook `hooks/pre-pushes/checkstyle-check` runs `mvn
checkstyle:checkstyle`, which is the
goal that writes a report. This PR changes it to `mvn checkstyle:check`,
the goal meant for
checking code against the rules, which is what a pre-push hook should run.
In practice, `checkstyle:checkstyle` also tried to download SNAPSHOT
artifacts during the hook,
which made pushes slow or fail when they weren't available locally. With
`checkstyle:check` the
hook finishes cleanly across all modules without resolving SNAPSHOT jars.
No change to the checkstyle rules or plugin configuration.
#### Release note
None (developer tooling only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
