havefunatcode commented on issue #18010: URL: https://github.com/apache/druid/issues/18010#issuecomment-6464178948
Hi @FrankChen021, I'd like to work on this if nobody else is (cc @CuteChuanChuan, are you still on it?). Doing every SQL function at once would be a big PR, so I'd start with the case in the description. With `'m1'` instead of `"m1"`, APPROX_QUANTILE and APPROX_QUANTILE_DS return NaN on master and APPROX_QUANTILE_FIXED_BUCKETS fails at runtime. I'd make those three throw `InvalidSqlInput` at planning time like #18949 (STRING columns would still work, since they're implicitly cast) and do the other functions in separate PRs. Is that OK with you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
