amaechler commented on code in PR #20734: URL: https://github.com/apache/druid/pull/20734#discussion_r4403232417
########## .github/scripts/static-checks-maven.sh: ########## @@ -19,21 +19,11 @@ set -e set -x echo 'Running Maven install...' -./mvnw -B clean install -q -ff -pl '!distribution' -P skip-tests -Dweb.console.skip=true -Dmaven.javadoc.skip=true -T1C +./mvnw -B install -q -ff -pl '!distribution' -P skip-tests -Dweb.console.skip=true -Dmaven.javadoc.skip=true -Dcyclonedx.skip ./mvnw -B checkstyle:checkstyle --fail-at-end -# Repo-wide RAT check. This is the only RAT pass in CI. It must run without -T: -# apache-rat-plugin 0.17+ shares per-run state across modules, so parallel runs -# can drop configured excludes or throw NPEs (RAT-553, fixed upstream by RAT-573). -./mvnw -B apache-rat:check -Prat --fail-at-end \ - -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn \ - -Drat.consoleOutput=true - -# The license dependency reports and check-licenses.py that used to run via -# license_checks_script.sh are covered by the packaging-check job, which builds -# the distribution with the apache-release profile. Not repeated here. -# ./.github/scripts/license_checks_script.sh +./mvnw -B apache-rat:check -Prat --fail-at-end -Drat.consoleOutput=true Review Comment: Apparently, we can remove this line too. > The in-build RAT run in packaging-check starts at the root module (`apache-rat:check (default) @ druid`) and scans the whole tree from the repo root, so `-pl '!benchmarks'` does not keep `benchmarks/` out of it. Repro on this branch: add `benchmarks/UNLICENSED_NOTE.md` without a license header, run `./mvnw -B verify -Prat -N -Pskip-static-checks`, and RAT fails with `/benchmarks/UNLICENSED_NOTE.md` under unapproved licenses. Since packaging-check runs on every PR with no path filter, this second pass only adds time: 68 s in this PR's static-checks-maven job (13:48:34 to 13:49:42). It also means the "RAT gap" item under Open and the benchmarks concern in the `ci.yml` thread are already covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
