amaechler opened a new pull request, #20797: URL: https://github.com/apache/druid/pull/20797
### Description Nothing has called `.github/scripts/license_checks_script.sh` since #20297. This PR deletes it. <details> Some thorough analysis from Claude about the history of the script: #### Where it came from - #8282 (ccd87d2667, 2019) added the license dependency reports to the Travis "license checks" job, next to its RAT check, to rebalance Travis job times. #8436 (984958122b) split out `check-licenses.py`, pointed the Travis job at it, and also bound it to `-Papache-release` in `distribution/pom.xml`. From then on the same check ran in two places: the Travis job and the release profile. - #13412 (30498c1f98, 2022) moved the static checks from Travis to GitHub Actions. The Travis job's `script:` block became `license_checks_script.sh`, called from `static-checks.yml`. Neither the PR nor any doc mentions running the script locally, and no doc has ever referenced it. `git log --follow --diff-filter=A` on this file reports #6076 (2018). That is a false rename match on the shared license header; #13412 created the file. #### How its callers went away | PR | Commit | Effect on the script | | --- | --- | --- | | #14005 | 774073b2e7 | Dropped the second call, with `-Phadoop3`, when Hadoop 3 became the default. | | #18893 | 66f7770fce | Moved the remaining call from `static-checks.yml` into `static-checks-maven.sh`. | | #20297 | 997a2a9568 | Added `-Papache-release` to `packaging-check.sh` and replaced the call with a standalone `apache-rat:check`. The call stayed behind as a comment, noting that `packaging-check` covers the reports and `check-licenses.py`. This was the last live call. | | #20734 | 63ddae805a | Removed the commented-out call and its note. | #20496 and #20707 still edited the script after #20297, to switch to `./mvnw` and to copy the pom's `--exclude-module-prefix` flags. Neither edit ran anywhere: the script only kept a second copy of the check's arguments that had to follow `distribution/pom.xml` by hand. #### What covers it today Both halves of the script still run in CI: - RAT: `static-checks-maven.sh` runs a repo-wide `apache-rat:check -Prat`, and `packaging-check.sh` builds with `-Prat`. - License reports and `check-licenses.py`: `packaging-check.sh` builds with `-Papache-release`, which runs the `generate-licenses-report`, `test-check-licenses` and `check-licenses` executions in `distribution/pom.xml`. For example, the packaging-check job of master run [40939403102](https://github.com/apache/druid/actions/runs/40939403102) logs `exec:3.6.4:exec (check-licenses) @ distribution`. To run the check locally, use the release build's executions, which read their arguments from the pom. #20775 documents them in the release guide, after a `mvn install` of the branch: ```bash mvn -Papache-release -pl distribution exec:exec@generate-licenses-report mvn -Papache-release -pl distribution exec:exec@check-licenses ``` </details> #### Release guide Drops "travis" from the `check-licenses` row in `distribution/asf-release-process-guide.md`. Travis CI was removed in #13789. <hr> This PR has: - [x] been self-reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
