akshat-lakhera commented on code in PR #20795:
URL: https://github.com/apache/druid/pull/20795#discussion_r4424216204
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/actions/SegmentAllocateActionTest.java:
##########
@@ -1277,10 +1236,7 @@ private void assertSameIdentifier(final
SegmentIdWithShardSpec expected, final S
private DataSegment getSegmentForIdentifier(SegmentIdWithShardSpec
identifier)
{
- return DataSegment.builder()
- .dataSource(identifier.getDataSource())
- .interval(identifier.getInterval())
- .version(identifier.getVersion())
+ return DataSegment.builder(SegmentId.of(identifier.getDataSource(),
identifier.getInterval(), identifier.getVersion(), 0))
Review Comment:
Switched to identifier.asSegmentId() here and in
ParallelIndexSupervisorTaskResourceTest. While I was at it I went through the
other chains in this PR where the partition in SegmentId.of didn't match the
shard spec, and fixed them too: a few in SegmentAllocateActionTest,
IndexerTableInputSpecSlicerTest, the LocalIntermediaryDataManager tests and
BrokerSegmentMetadataCacheTest now use the shard spec's partition, and the two
benchmarks pass the shardSpec straight to SegmentId.of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
