FrankChen021 commented on code in PR #20799:
URL: https://github.com/apache/druid/pull/20799#discussion_r4429463828
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/CalciteRulesManager.java:
##########
@@ -500,9 +498,20 @@ public List<RelOptRule> bindableConventionRuleSet(final
PlannerContext plannerCo
.build();
}
- public List<RelOptRule> configurableRuleSet(PlannerContext plannerContext)
+ /**
+ * Returns a {@link ProjectMergeRule} that uses the bloat from the query
context.
+ */
+ private ProjectMergeRule projectMergeRule(PlannerContext plannerContext)
Review Comment:
[P2] Removing configurableRuleSet breaks compatibility
**Finding:** Replacing the public configurableRuleSet(PlannerContext) method
with a private helper removes a method from CalciteRulesManager's public API.
Downstream code compiled against it can fail with NoSuchMethodError, and
subclasses that previously overrode it can no longer customize the rules used
by baseRuleSet.
**Suggestion:** Retain a deprecated compatibility method and preserve the
existing override hook, or coordinate its removal through the normal API and
extension compatibility process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
