FrankChen021 commented on code in PR #20782:
URL: https://github.com/apache/druid/pull/20782#discussion_r4442525698


##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/OperatorConversions.java:
##########
@@ -594,6 +605,13 @@ protected SqlOperandTypeInference 
buildOperandTypeInference()
       final IntSet nullableOperands = requiredOperandCount == null
           ? new IntArraySet()
           : 
DefaultOperandTypeChecker.buildNullableOperands(requiredOperandCount, 
operandTypes.size(), new IntArraySet());
+      if (operandTypes != null) {

Review Comment:
   Rechecked the current head and all 22 changed files: custom checker 
operators remain null-safe, nullable handling is centralized in 
buildNullableOperands, and the regression coverage is present. No remaining 
issue from this thread.
   
   <!-- mergelens:review -->



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to