sakshichitnis27 commented on PR #20813: URL: https://github.com/apache/druid/pull/20813#issuecomment-6581496547
Thanks for the review. CI is green on all checks. To double-check that the cache now behaves exactly like SqlSegmentsMetadataQuery#markSegmentsUnused, I ran a throwaway differential test (not included in this PR): ~40 segments (hourly/daily/monthly, multiple partitions and versions, cross-year, year 0000/9999 and ETERNITY) against ~4000 query intervals x 6 version filters. The SQL path (Derby) and the cache agreed on both the update count and the exact set of segments marked unused in all 24,000 cases. The same harness fails immediately on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
