capistrant commented on code in PR #20805:
URL: https://github.com/apache/druid/pull/20805#discussion_r4474794209
##########
multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ScanQueryStageProcessor.java:
##########
@@ -42,29 +43,25 @@
import org.apache.druid.segment.loading.AcquireMode;
import org.apache.druid.sql.calcite.filtration.Filtration;
-import javax.annotation.Nullable;
-import java.util.concurrent.atomic.AtomicLong;
-
@JsonTypeName("scan")
public class ScanQueryStageProcessor extends BaseLeafStageProcessor
{
private final ScanQuery query;
/**
- * Instantiated and passed to all the {@link ScanQueryFrameProcessor}s
created from this factory to keep a track
- * of the number of rows processed so far in case the query is limited
(without any order by) because one doesn't need
- * to scan through all the rows in that case.
- * This is not ideal because nothing really guarantees this factory is used
for a single makeWorkers call
+ * Shared by all the {@link ScanQueryFrameProcessor}s created from this
factory, so a limited scan stops reading once
+ * rows can no longer contribute to the result. Holds the state of one
execution: each work order deserializes its
Review Comment:
re-wrote to something that hopefully makes more sense and still make it
clear that execute must not be called multiple times
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
