FrankChen021 commented on code in PR #20839:
URL: https://github.com/apache/druid/pull/20839#discussion_r4480568668
##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafkainput/KafkaInputFormat.java:
##########
@@ -73,7 +76,8 @@ public KafkaInputFormat(
@JsonProperty("timestampColumnName") @Nullable String
timestampColumnName,
@JsonProperty("topicColumnName") @Nullable String topicColumnName,
@JsonProperty("partitionColumnName") @Nullable String
partitionColumnName,
- @JsonProperty("offsetColumnName") @Nullable String offsetColumnName
+ @JsonProperty("offsetColumnName") @Nullable String offsetColumnName,
+ @JsonProperty("keyColumnPrefix") @Nullable String keyColumnPrefix
Review Comment:
[P2] Preserve the existing public constructor
**Finding:** Appending `keyColumnPrefix` removes the previous public
`KafkaInputFormat` constructor signature, so Java callers compiled against the
prior release can fail with `NoSuchMethodError` or fail to compile even when
they do not use the new option. The corresponding public `KafkaInputReader`
constructor is changed in the same way.
**Suggestion:** Retain overloads for the previous `KafkaInputFormat` and
`KafkaInputReader` signatures, delegating to the new constructors with a null
prefix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
