capistrant commented on code in PR #20851:
URL: https://github.com/apache/druid/pull/20851#discussion_r4482750208
##########
processing/src/main/java/org/apache/druid/segment/file/PartialSegmentFileMapperV10.java:
##########
@@ -548,27 +549,41 @@ public ByteBuffer mapExternalFile(String filename, String
name) throws IOExcepti
* {@code acquireSegment} path on partial-eligible segments to force the
segment fully resident before returning.
* Each container downloads via {@link #fetchFiles}, so a not-yet-downloaded
container fetches in a single range
* read (its files tile back-to-back), and a partially-downloaded container
skips its already-resident spans.
+ * <p>
+ * {@code continueDownloading} is consulted before each container fetch
(including each attached external
Review Comment:
nit: better to use `@param` I think
##########
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java:
##########
@@ -2236,8 +2255,15 @@ private interface AcquireTaskBody
* act: after the fold, ownership of every registered hold lives inside
the returned result's segment (or was
* closed by the fold on a miss), and nothing that can throw may run
between the fold and returning. On any
* throw before the fold, {@link #submitAcquireTask} closes {@code
taskHolds}.
+ * <p>
+ * {@code continueLoading} reports whether anyone still wants this acquire
(false once the action has been
Review Comment:
nit: `@param` here too potentially? but I guess the existing params don't do
so already so 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
