FrankChen021 commented on code in PR #20845: URL: https://github.com/apache/druid/pull/20845#discussion_r4480369368
########## sql/src/test/quidem/org.apache.druid.quidem.SqlQuidemTest/numeric_agg_string_args.iq: ########## @@ -3,6 +3,7 @@ # Numeric aggregators on STRING columns and string literals. # A STRING column is implicitly cast to a number for SUM, AVG and COUNT; MIN and MAX reject it. +# A string literal that cannot be parsed as a number is rejected by SUM and AVG. Review Comment: Thanks for updating this. I rechecked the current head: the comment now covers numeric aggregators and includes SUM, AVG, and BIT_AND, so the nit is addressed. Reviewed 1 of 5 changed files in this reply-only follow-up; no further action is needed for this thread. <!-- mergelens:review --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
