FrankChen021 commented on code in PR #20830:
URL: https://github.com/apache/druid/pull/20830#discussion_r4476277579
##########
server/src/main/java/org/apache/druid/server/QueryResource.java:
##########
@@ -300,6 +301,10 @@ private Query<?> readQuery(
catch (ValueInstantiationException e) {
throw new BadJsonQueryException(e);
}
+ catch (JsonMappingException e) {
Review Comment:
Fixed in 0f3d5a5254: `InvalidDefinitionException` is now rethrown before the
`JsonMappingException` catch, so it still goes to the catch-all 500 path.
`testQueryWithBrokenDefinitionIsServerError` covers it. I kept the broad catch
so other input-side subclasses, such as `UnrecognizedPropertyException` and
`InvalidFormatException`, still return 400.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
