FrankChen021 commented on code in PR #20848:
URL: https://github.com/apache/druid/pull/20848#discussion_r4480415227
##########
services/src/main/java/org/apache/druid/guice/PeonServerModule.java:
##########
@@ -81,17 +81,23 @@ public Server getServer(
@VisibleForTesting
static ServerConfig adjustServerConfig(final ServerConfig config, final Task
task)
{
- if (Period.ZERO.equals(config.getUnannouncePropagationDelay()) ||
isQueryable(task)) {
+ if ((Period.ZERO.equals(config.getUnannouncePropagationDelay())
Review Comment:
[P1] Update stale peon shutdown tests
**Finding:** With the new `ServerConfig` default of `PT30S`, a non-queryable
`NoopTask.forDatasource("wiki")` now enters this branch even when the
unannounce delay is zero, and the returned config changes the graceful shutdown
timeout to `PT0S`. The existing `PeonServerModuleTest#testZeroDelayIsUnchanged`
still expects the same object, while
`testNonQueryableTaskIgnoresUnannounceDelay` expects a config retaining the
30-second timeout; these assertions fail on the reviewed head and block the
services test suite.
**Suggestion:** Update `PeonServerModuleTest` to assert the intended `PT0S`
graceful-timeout override for non-queryable tasks and cover the explicit
zero/zero fast path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
