leventov commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-477794972 For reviewers: in the latest commits I've made some more clarification renames: - `KillTask` -> `KillUnusedSegmentsTask` - `TaskMonitor.killTask()` -> `cancelTask()` (see also related #7361) - `IndexingServiceClient.killTask()` -> `cancelTask()` - `IndexingServiceClient.killSegments()` -> `killUnusedSegments()` - `ClientQuery` -> `ClientTaskQuery` - `ClientKillQuery` -> `ClientKillUnusedSegmentsTaskQuery` - `ClientCompactQuery` -> `ClientCompactionTaskQuery` - `ClientCompactQueryTuningConfig` -> `ClientCompactionTaskQueryTuningConfig` `CoordinatorDynamicConfig` parameters: - `millisToWaitBeforeDeleting` -> `millisLagSinceCoordinatorBecomesLeaderBeforeCanMarkAsUnusedOvershadowedSegments` - `killAllDataSources` -> `killUnusedSegmentsInAllDataSources` - `specificDataSourcesToKill` -> `specificDataSourcesToKillUnusedSegmentsIn` - `protectedPendingSegmentDatasources` -> `dataSourcesToNotKillStalePendingSegmentsIn` I kept the old names of JSON properties because aliases (for backward compatibility) are only supported in Jackson 2.9, see #7152. DruidCoordinatorHelpers: - `DruidCoordinatorCleanupPendingSegments` -> `DruidCoordinatorKillStalePendingSegments` - `DruidCoordinatorCleanupUnusedSegments` -> `DruidCoordinatorUnloadUnusedSegments` - `DruidCoordinatorCleanupOvershadowed` -> `DruidCoordinatorMarkAsUnusedOvershadowedSegments` - `DruidCoordinatorSegmentKiller` -> `DruidCoordinatorUnusedSegmentsKiller` (Next steps will be: remove "DruidCoordinator" prefixes and make all class names noun phrases or verb phrases, but not a mix.)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
