mohammadjkhan commented on a change in pull request #6972: Support LDAP
authentication/authorization
URL: https://github.com/apache/incubator-druid/pull/6972#discussion_r270509304
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/db/updater/CoordinatorBasicAuthenticatorMetadataStorageUpdater.java
##########
@@ -156,6 +161,9 @@ public void start()
)
);
}
+
+ BasicAuthConfig config = new BasicAuthConfig(dbConfig);
Review comment:
I started out on this path first of having a separate BasicAuthLDAPConfig
but remember running into some issues that I can't specifically recall. I don't
recall trying to inject it using guice, so I'll look into further. Great
suggestion, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
