jihoonson commented on a change in pull request #7338: Overwrite index task
maxTotalRows with computed maxRowsPerSegments
URL: https://github.com/apache/incubator-druid/pull/7338#discussion_r270984050
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -866,7 +866,7 @@ IndexTuningConfig
computeTuningConfig(List<Pair<QueryableIndex, DataSegment>> qu
nonNullTargetCompactionSizeBytes
);
return (tuningConfig == null ? IndexTuningConfig.createDefault() :
tuningConfig)
- .withMaxRowsPerSegment(maxRowsPerSegment);
+
.withMaxRowsPerSegment(maxRowsPerSegment).withMaxTotalRows(Long.MAX_VALUE);
Review comment:
Would you please add a comment here why we set `maxTotalRows` to
`Long.MAX_VALUE`? Probably it goes like `Setting maxTotalRows to Long.MAX_VALUE
to respect the computed maxRowsPerSegment. If this is set to something too
small, compactionTask can generate small segments which need to be compacted
again, which in turn making auto compaction stuck in the same interval`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
