lxqfy commented on a change in pull request #7338: Overwrite index task
maxTotalRows with computed maxRowsPerSegments
URL: https://github.com/apache/incubator-druid/pull/7338#discussion_r271117823
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java
##########
@@ -866,7 +866,7 @@ IndexTuningConfig
computeTuningConfig(List<Pair<QueryableIndex, DataSegment>> qu
nonNullTargetCompactionSizeBytes
);
return (tuningConfig == null ? IndexTuningConfig.createDefault() :
tuningConfig)
- .withMaxRowsPerSegment(maxRowsPerSegment);
+
.withMaxRowsPerSegment(maxRowsPerSegment).withMaxTotalRows(Long.MAX_VALUE);
Review comment:
@jihoonson Yes, of course. I have added the comments. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
