clintropolis commented on a change in pull request #7138: 'core' ORC extension
URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r273300645
##########
File path:
extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java
##########
@@ -139,18 +155,46 @@ private static Object convertPrimitive(TypeDescription
fieldDescription, Writabl
* primitive types will be extracted into an ingestion friendly state (e.g.
'int' and 'long'). Finally,
* if a field is not present, this method will return null.
*
- * Note: "Union" types are not currently supported and will be returned as
null
+ * Note: "Union" types are not currently supported and will be returned as
null. Additionally, this method
+ * has a cache of field names to field index that is ONLY valid for the root
level {@link OrcStruct}, and should
Review comment:
Agree, will fix :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
