surekhasaharan commented on a change in pull request #7325: Fix result-level cache for queries URL: https://github.com/apache/incubator-druid/pull/7325#discussion_r274641008
########## File path: processing/src/main/java/org/apache/druid/query/groupby/having/GreaterThanHavingSpec.java ########## @@ -119,4 +123,36 @@ public String toString() sb.append('}'); return sb.toString(); } + + @Override + public byte[] getCacheKey() + { + try { + final ByteArrayOutputStream outputStream = new ByteArrayOutputStream(); Review comment: Yeah, I can use CacheKeyBuilder, wonder why I didn't earlier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org