KazuhitoT commented on issue #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#issuecomment-483292472 @gianm Thanks for your reviewing. Summary of changes are as follows: - Replaced `protected` with `private`. - Updated `sql.md`. - Used `DruidExpression.fromFunctionCall`. - Modified tests, replaced `ClassCast Exception` with `IAE Exception`. Travis job failed but it seems to be caused by some server errors. (My Travis job works: https://travis-ci.org/KazuhitoT/incubator-druid) So, could you restart it and confirm if it's ok?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
