gianm commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276411745
########## File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/BloomFilterAggregateCombiner.java ########## @@ -24,11 +24,12 @@ import org.apache.druid.segment.ColumnValueSelector; import javax.annotation.Nullable; +import java.nio.ByteBuffer; -public class BloomFilterAggregateCombiner extends ObjectAggregateCombiner<BloomKFilter> Review comment: AggregateCombiner is only used at ingestion time AFAIK. Since this aggregator isn't meant to be used at ingestion time, you might as well delete this and make `makeAggregateCombiner` throw an UnsupportedOperationException. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
