justinborromeo edited a comment on issue #7238: [PROPOSAL] Add segment limit for native and streaming index tasks URL: https://github.com/apache/incubator-druid/issues/7238#issuecomment-484273106 After taking a first crack at this, I've realized that publishing segments once the number of segments in the Appenderator exceeded some limit results in the limit row being stored in its one-row segment. This is because the proposed implementation checks number of segments _after_ the row had been stored. A better behaviour would involve checking the number of segments _before_ the row had been stored to prevent the creation of one-row segments.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
