clintropolis commented on a change in pull request #7496: refactor druid-bloom-filter aggregators URL: https://github.com/apache/incubator-druid/pull/7496#discussion_r276536440
########## File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/DoubleBloomFilterAggregator.java ########## @@ -23,20 +23,22 @@ import org.apache.druid.query.filter.BloomKFilter; import org.apache.druid.segment.BaseDoubleColumnValueSelector; +import java.nio.ByteBuffer; + public final class DoubleBloomFilterAggregator extends BaseBloomFilterAggregator<BaseDoubleColumnValueSelector> Review comment: Heh, originally the bloom filter aggregators were done like that, [refactored in the original PR in this commit](https://github.com/apache/incubator-druid/pull/6397/commits/74feb9750eeca367728a6ee60b677994fe7e18f0), but it actually takes more classes to implement it that way (especially the way it is in this PR), and puts more indirection between the aggregators which doesn't really seem necessary. See [this comment chain original PR for reference](https://github.com/apache/incubator-druid/pull/6397#discussion_r250564034), and the issue spawned from it, #6909 for more details. I think I find it cleaner this way personally, especially after the changes of this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
