vogievetsky commented on a change in pull request #7493: No SQL mode in web
console
URL: https://github.com/apache/incubator-druid/pull/7493#discussion_r276869715
##########
File path: web-console/src/views/segments-view.tsx
##########
@@ -42,27 +42,47 @@ import './segments-view.scss';
const tableColumns: string[] = ['Segment ID', 'Datasource', 'Start', 'End',
'Version', 'Partition',
'Size', 'Num rows', 'Replicas', 'Is published', 'Is realtime', 'Is
available'];
+const tableColumnsNoSql: string[] = ['Segment ID', 'Datasource', 'Start',
'End', 'Version', 'Partition', 'Size'];
export interface SegmentsViewProps extends React.Props<any> {
goToSql: (initSql: string) => void;
datasource: string | null;
onlyUnavailable: boolean | null;
+ noSqlMode: boolean;
}
export interface SegmentsViewState {
segmentsLoading: boolean;
segments: any[] | null;
segmentsError: string | null;
segmentFilter: Filter[];
+ allSegments?: any[] | null;
Review comment:
should this any really be `SegmentQueryResultRow` ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
