gianm commented on a change in pull request #7425: Add is_overshadowed column 
to sys.segments table
URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r276876625
 
 

 ##########
 File path: 
sql/src/main/java/org/apache/druid/sql/calcite/schema/MetadataSegmentView.java
 ##########
 @@ -195,7 +204,7 @@ private void poll()
         sb.append("datasources=").append(ds).append("&");
       }
       sb.setLength(sb.length() - 1);
-      query = "/druid/coordinator/v1/metadata/segments?" + sb;
+      query = 
"/druid/coordinator/v1/metadata/segments?includeOvershadowedStatus?" + sb;
 
 Review comment:
   I'm not sure if doing two `?` in the same URL works, but even if it does, 
it's poor form; the second one should be a `&`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to