leventov commented on a change in pull request #7088: Improve parallelism of
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277038897
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
##########
@@ -183,28 +172,17 @@ public void dropSegment(
final LoadPeonCallback callback
Review comment:
Methods and fields in this class generally lack concurrent access
documentation:
https://github.com/code-review-checklists/java-concurrency#justify-document.
For example, it's not clear if you removed synchronization in `dropSegment()`
method because it's called only from a single thread, or because you think the
new code is concurrently safe. If the latter, then `dropSegment()` seems to be
a subject for
https://github.com/code-review-checklists/java-concurrency#chm-race
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
