samarthjain commented on a change in pull request #7088: Improve parallelism of
zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277044531
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java
##########
@@ -431,34 +392,28 @@ public int getType()
return type;
}
- public SegmentId getSegmentId()
+ public String getSegmentIdentifier()
Review comment:
SegmentHolder is an inner class and almost all the callers who need
segmentIdentifier need the string version of it. So it made more sense to me to
just return the String instead of having callers call toString() on segmentId.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
