surekhasaharan commented on a change in pull request #7425: Add is_overshadowed column to sys.segments table URL: https://github.com/apache/incubator-druid/pull/7425#discussion_r277472998
########## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorRuleRunner.java ########## @@ -141,13 +139,8 @@ public DruidCoordinatorRuntimeParams run(DruidCoordinatorRuntimeParams params) private Set<DataSegment> determineOvershadowedSegments(DruidCoordinatorRuntimeParams params) Review comment: yeah, it's similar, except input args and return type. I think `getFullyOvershadowedSegments` would be useful as it's public and can be used by anyone with a datasource object, i don't see how i can use that one in here though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
