This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch 0.14.1-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
commit 2114325fd38c0e612c1cc8c49ca1036278d06793 Author: Qi Chen <[email protected]> AuthorDate: Sat Apr 20 11:39:50 2019 +0800 Fix too many dentry cache slab objs#7508. (#7509) --- .../druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java b/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java index d9f5d1d..3269d47 100644 --- a/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java +++ b/processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/LimitedTemporaryStorage.java @@ -54,6 +54,8 @@ public class LimitedTemporaryStorage implements Closeable private volatile boolean closed = false; + private boolean createdStorageDirectory = false; + public LimitedTemporaryStorage(File storageDirectory, long maxBytesUsed) { this.storageDirectory = storageDirectory; @@ -81,6 +83,9 @@ public class LimitedTemporaryStorage implements Closeable } FileUtils.forceMkdir(storageDirectory); + if (!createdStorageDirectory) { + createdStorageDirectory = true; + } final File theFile = new File(storageDirectory, StringUtils.format("%08d.tmp", files.size())); final EnumSet<StandardOpenOption> openOptions = EnumSet.of( @@ -126,7 +131,7 @@ public class LimitedTemporaryStorage implements Closeable delete(file); } files.clear(); - if (storageDirectory.exists() && !storageDirectory.delete()) { + if (createdStorageDirectory && storageDirectory.exists() && !storageDirectory.delete()) { log.warn("Cannot delete storageDirectory: %s", storageDirectory); } } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
