Hailei commented on a change in pull request #7540: call threadlocal.remove
explicitly to avoid CPU usage spikes
URL: https://github.com/apache/incubator-druid/pull/7540#discussion_r278490886
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ConcurrentGrouper.java
##########
@@ -409,6 +409,7 @@ public void close()
{
if (!closed) {
closed = true;
+ threadLocalGrouper.remove();
Review comment:
Can we use hashmap(ConcurentHashMap<Thread,SpillingGrouper>) instead of
threadlocal?
Another way Add a method that is responsible for calling
threadLocalGrouper.remove,it can be called in the processing thread
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
