vogievetsky commented on a change in pull request #7551: Add supervisor card in
home view
URL: https://github.com/apache/incubator-druid/pull/7551#discussion_r278747531
##########
File path: web-console/src/views/home-view.tsx
##########
@@ -332,6 +367,18 @@ GROUP BY 1`);
error: state.datasourceCountError
})}
+ {this.renderCard({
+ href: '#tasks',
+ icon: IconNames.LIST_COLUMNS,
+ title: 'Supervisors',
+ loading: state.supervisorCountLoading,
+ content: <>
+ <p>{pluralIfNeeded(state.runningSupervisorCount, 'running
supervisor')}</p>
+ <p>{pluralIfNeeded(state.suspendedSupervisorCount, 'suspended
supervisor')}</p>
+ </>,
Review comment:
alignment. Also if there are no supervisors it I think it should just say "0
supervisors"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
