jon-wei commented on a change in pull request #7490: Add reload by interval API
URL: https://github.com/apache/incubator-druid/pull/7490#discussion_r279100734
##########
File path:
server/src/test/java/org/apache/druid/metadata/SQLMetadataSegmentManagerTest.java
##########
@@ -276,6 +297,432 @@ public void testRemoveDataSegment() throws IOException
Assert.assertTrue(manager.removeSegment(newSegment.getId()));
}
+ @Test
+ public void testEnableSegmentsWithSegmentIds() throws IOException
+ {
+ manager.start();
+ manager.poll();
+ Assert.assertTrue(manager.isStarted());
+
+ final String datasource = "wikipedia2";
+ final DataSegment newSegment1 = new DataSegment(
+ datasource,
+ Intervals.of("2017-10-15T00:00:00.000/2017-10-16T00:00:00.000"),
+ "2017-10-15T20:19:12.565Z",
+ ImmutableMap.of(
+ "type", "s3_zip",
+ "bucket", "test",
+ "key",
"wikipedia2/index/y=2017/m=10/d=15/2017-10-16T20:19:12.565Z/0/index.zip"
+ ),
+ ImmutableList.of("dim1", "dim2", "dim3"),
+ ImmutableList.of("count", "value"),
+ NoneShardSpec.instance(),
+ 0,
+ 1234L
+ );
+
+ final DataSegment newSegment2 = new DataSegment(
+ datasource,
+ Intervals.of("2017-10-15T00:00:00.000/2017-10-16T00:00:00.000"),
+ "2017-10-15T20:19:12.565Z",
+ ImmutableMap.of(
+ "type", "s3_zip",
+ "bucket", "test",
+ "key",
"wikipedia2/index/y=2017/m=10/d=15/2017-10-16T20:19:12.565Z/0/index.zip"
+ ),
+ ImmutableList.of("dim1", "dim2", "dim3"),
+ ImmutableList.of("count", "value"),
+ NoneShardSpec.instance(),
+ 1,
+ 1234L
+ );
+
+ // Overshadowed by newSegment2
+ final DataSegment newSegment3 = new DataSegment(
+ datasource,
+ Intervals.of("2017-10-15T00:00:00.000/2017-10-16T00:00:00.000"),
+ "2017-10-15T20:19:12.565Z",
Review comment:
To match what the test is trying to check, the version on newSegment3 needs
to be lower than the versions on 1 and 2.
All of the segments here have the same version and interval currently (same
iD), so the publish calls are really only publishing one segment three times.
This set matches iterateAllSegments right now `ImmutableSet.of(segment1,
segment2, newSegment1, newSegment2)` because DataSegment is hashed by ID only
and newSegment1 and newSegment2 are identical in that respect (so it's really a
3 item set).
Please adjust the version timestamps here and in other tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
