justinborromeo commented on a change in pull request #7514: Introduce segment 
limit for indexing tasks
URL: https://github.com/apache/incubator-druid/pull/7514#discussion_r279114737
 
 

 ##########
 File path: 
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AppenderatorDriverRealtimeIndexTask.java
 ##########
 @@ -313,6 +316,23 @@ public TaskStatus run(final TaskToolbox toolbox)
             log.debug("Discarded null row, considering thrownAway.");
             rowIngestionMeters.incrementThrownAway();
           } else {
+            // Check if the upcoming row will result in the creation of a new 
segment.  If so and the new number of segments
 
 Review comment:
   I think that's doable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to