jihoonson commented on a change in pull request #7531: Data loader (sampler component) URL: https://github.com/apache/incubator-druid/pull/7531#discussion_r279938345
########## File path: .gitignore ########## @@ -13,5 +13,7 @@ target *.log *.DS_Store _site +indexing-service/foo/* +indexing-service/testDataSource/* Review comment: Hmm it looks that these directories are used in some tests, but I think any test directory should be under `$PACKAGE_ROOT/target/`. How about fixing those tests rather than adding these directories to `.gitignore`? I would like to not add them because they would remind me this issue whenever I see them. I don't think finding and fixing tests don't have to be done in this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
