FaxianZhao edited a comment on issue #6726: #6336 causes overlord console page 
loading to be extreme slow
URL: 
https://github.com/apache/incubator-druid/issues/6726#issuecomment-491145454
 
 
   I suggest use the Fine-Grained Lock resolve this kind issues. 
   I think my previous draft code won't cause this, because I use `synchronized 
(lockResult.getTaskLock())` instead of 
`toolbox.getTaskLockbox().doInCriticalSection`, but it looks bad for committed 
code.
   
   I think we could push down lock action to the TaskLock level. Giant lock is 
used to approve TaskLock, and TaskLock is work for the real business. We could 
implement TaskLockType with ReadWriteLock, but I haven't go through the whole 
picture.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to