leventov commented on a change in pull request #7681: Add checkstyle for "Local
variable names shouldn't start with capital"
URL: https://github.com/apache/incubator-druid/pull/7681#discussion_r285196629
##########
File path:
extensions-contrib/ambari-metrics-emitter/src/main/java/org/apache/druid/emitter/ambari/metrics/AmbariMetricsEmitter.java
##########
@@ -230,7 +230,7 @@ public void close()
protected static String sanitize(String namespace)
{
- Pattern DOT_OR_WHITESPACE = Pattern.compile("[\\s]+|[.]+");
- return DOT_OR_WHITESPACE.matcher(namespace).replaceAll("_");
+ Pattern dotOrWhitespace = Pattern.compile("[\\s]+|[.]+");
Review comment:
It should rather be a constant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
