clintropolis commented on a change in pull request #7564: Add segment timeline chart in datasource view URL: https://github.com/apache/incubator-druid/pull/7564#discussion_r285361078
########## File path: web-console/src/components/segment-timeline.tsx ########## @@ -0,0 +1,393 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import {Button, FormGroup, HTMLSelect, Radio, RadioGroup} from '@blueprintjs/core'; +import * as d3 from 'd3'; +import { AxisScale } from 'd3'; +import * as React from 'react'; + +import { formatBytes, queryDruidSql, QueryManager } from '../utils'; +import { StackedBarChart } from '../visualization/stacked-bar-chart'; + +import { Loader } from './loader'; +import {ViewControlBar} from './view-control-bar'; + +import './segment-timeline.scss'; + +interface SegmentTimelineProps extends React.Props<any> { + chartHeight: number; + chartWidth: number; +} + +interface SegmentTimelineState { + data: Record<string, any>; + datasources: string[]; + stackedData: Record<string, BarUnitData[]>; + singleDatasourceData: Record<string, Record<string, BarUnitData[]>>; + activeDatasource: string | null; + activeDataType: string; // "countData" || "sizeData" + dataToRender: BarUnitData[]; + timeSpan: number; // by months + loading: boolean; + error: string | null; + xScale: AxisScale<Date> | null; + yScale: AxisScale<number> | null; +} + +interface BarChartScales { + xScale: AxisScale<Date>; + yScale: AxisScale<number>; +} + +export interface BarUnitData { + x: number; + y: number; + y0?: number; + width: number; + datasource: string; + color: string; +} + +export interface BarChartMargin { + top: number; + right: number; + bottom: number; + left: number; +} + +export class SegmentTimeline extends React.Component<SegmentTimelineProps, SegmentTimelineState> { + private dataQueryManager: QueryManager<string, any>; + private datasourceQueryManager: QueryManager<string, any>; + private colors = ['b33040', '#d25c4d', '#f2b447', '#d9d574', '#4FAA7E', '#57ceff', '#789113', '#098777', + 'b33040', '#d2757b', '#f29063', '#d9a241', '#80aa61', '#c4ff9e', '#915412', '#87606c']; + private chartMargin = { top: 20, right: 10, bottom: 20, left: 10 }; + + constructor(props: SegmentTimelineProps) { + super(props); + this.state = { + data: {}, + datasources: [], + stackedData: {}, + singleDatasourceData: {}, + dataToRender: [], + activeDatasource: null, + activeDataType: 'countData', + timeSpan: 3, + loading: true, + error: null, + xScale: null, + yScale: null + }; + } + + componentDidMount(): void { + this.dataQueryManager = new QueryManager({ + processQuery: async (dummy: string) => { + const { timeSpan } = this.state; + const query = `SELECT "start", "end", "datasource", COUNT(*) AS "count", sum(size) as "total_size" + FROM sys.segments + WHERE "start" > time_format(TIMESTAMPADD(MONTH, -${timeSpan}, current_timestamp), 'yyyy-MM-dd''T''hh:mm:ss.SSS') + GROUP BY 1, 2, 3 + ORDER BY "start" DESC`; + const resp: any[] = await queryDruidSql({ query }); + const data = this.processRawData(resp); + const stackedData = this.calculateStackedData(data); + const singleDatasourceData = this.calculateSingleDatasourceData(data); + return { data, stackedData, singleDatasourceData }; + }, + onStateChange: ({ result, loading, error }) => { + if (result === null) return; + this.setState({ + data: result.data, + stackedData: result.stackedData, + singleDatasourceData: result.singleDatasourceData, + loading, + error + }); + } + }); + + this.dataQueryManager.runQuery('dummy'); + + this.datasourceQueryManager = new QueryManager({ + processQuery: async (dummy: string) => { + const query = `SELECT DISTINCT "datasource" FROM sys.segments`; + const resp: any[] = await queryDruidSql({ query }); + const data = resp.map((r: any) => r.datasource); + return data; + }, + onStateChange: ({ result, loading, error }) => { + if (result == null) result = []; + this.setState({ + datasources: result + }); + } + }); + + this.datasourceQueryManager.runQuery('dummy'); + + } + + componentWillUnmount(): void { + this.dataQueryManager.terminate(); + this.datasourceQueryManager.terminate(); + } + + componentDidUpdate(prevProps: SegmentTimelineProps, prevState: SegmentTimelineState): void { + const { activeDatasource, activeDataType, singleDatasourceData, stackedData, data } = this.state; + if (prevState.data !== this.state.data || + prevState.activeDataType !== this.state.activeDataType || + prevState.activeDatasource !== this.state.activeDatasource || + prevProps.chartWidth !== this.props.chartWidth || + prevProps.chartHeight !== this.props.chartHeight) { + const scales: BarChartScales | null = this.calculateScales(); + const dataToRender: BarUnitData[] = activeDatasource + ? singleDatasourceData[activeDataType][activeDatasource] + : stackedData[activeDataType]; + if (scales) { + this.setState({ + dataToRender, + xScale: scales.xScale, + yScale: scales.yScale + }); + } + } + } + + private processRawData(data: any) { + if (data === null) return []; + const countData: {[key: string]: any} = {}; + const sizeData: {[key: string]: any} = {}; + data.forEach((entry: any) => { + const start = entry.start; + const day = start.split('T')[0]; + const datasource = entry.datasource; + const count = entry.count; + const segmentSize = entry['total_size']; + if (countData[day] === undefined) { + countData[day] = { + day, + [datasource]: count, + total: count + }; + sizeData[day] = { + day, + [datasource]: segmentSize, + total: segmentSize + }; + } else { + const countDataEntry = countData[day][datasource]; + countData[day][datasource] = count + (countDataEntry === undefined ? 0 : countDataEntry); + const sizeDataEntry = sizeData[day][datasource]; + sizeData[day][datasource] = segmentSize + (sizeDataEntry === undefined ? 0 : sizeDataEntry); + countData[day].total += count; + sizeData[day].total += segmentSize; + } + }); + const countDataArray = Object.keys(countData).reverse().map((time: any) => { + return countData[time]; + }); + const sizeDataArray = Object.keys(sizeData).reverse().map((time: any) => { + return sizeData[time]; + }); + return {countData: countDataArray, sizeData: sizeDataArray}; + } + + private calculateStackedData(data: Record<string, any>): Record<string, BarUnitData[]> { + const { datasources } = this.state; + const newStackedData: Record<string, BarUnitData[]> = {}; + Object.keys(data).forEach((type: any) => { + const stackedData: any = data[type].map((d: any) => { + let y0 = 0; + return datasources.map((datasource: string, i) => { + const barUnitData = { + x: d.day, + y: d[datasource] === undefined ? 0 : d[datasource], + y0, + datasource, + color: this.colors[i] + }; + y0 += d[datasource] === undefined ? 0 : d[datasource]; + return barUnitData; + }); + }); + newStackedData[type] = stackedData.flat(); + }); + return newStackedData; + } + + private calculateSingleDatasourceData(data: Record<string, any>): Record<string, Record<string, BarUnitData[]>> { + const { datasources } = this.state; + const singleDatasourceData: Record<string, Record<string, BarUnitData[]>> = {}; + Object.keys(data).forEach((dataType) => { + singleDatasourceData[dataType] = {}; + datasources.forEach((datasource, i) => { + const currentData = data[dataType]; + if (currentData.length === 0) return; + const dataResult = currentData.map((d: any) => { + let y = 0; + if (d[datasource] !== undefined) { + y = d[datasource]; + } + return { + x: d.day, + y, + datasource, + color: this.colors[i] + }; + }); + if (!dataResult.every((d: any) => d.y === 0)) singleDatasourceData[dataType][datasource] = dataResult; + }); + }); + return singleDatasourceData; + } + + private calculateScales(): BarChartScales | null { + const { chartWidth, chartHeight} = this.props; + const {data, activeDataType, activeDatasource, singleDatasourceData } = this.state; + if (Object.keys(data).length === 0) return null; + const activeData = data[activeDataType]; + const xDomain: Date[] = [new Date(activeData[0].day), new Date(activeData[activeData.length - 1].day)]; Review comment: This explodes for me if there is no segment data in the last `timeSpan` months queried: <img width="1418" alt="Screen Shot 2019-05-18 at 4 24 02 AM" src="https://user-images.githubusercontent.com/1577461/57976712-a95f5600-799b-11e9-919b-c56c41707d9c.png";> A further issue, scaling like this based on the data that exists time range, rather than the complete time interval (e.g. last 3 months) feels wrong to me, like if I have a day worth of data and have the last 3 months selected, I think the xdomain should be the whole interval being instead of: <img width="1675" alt="Screen Shot 2019-05-18 at 6 17 44 PM" src="https://user-images.githubusercontent.com/1577461/57976723-ce53c900-799b-11e9-8ceb-0340aadc4c06.png";> Replacing the xDomain with something like ``` const dStart = new Date(); const dEnd = new Date(); dStart.setMonth(dStart.getMonth() - timeSpan); const xDomain: Date[] = [dStart, dEnd]; ``` solves that part without depending on there being data in the interval queried, however the bar with of the segment(s) being plotted is also scaled based on the number of available data points, so that presents another problem: <img width="1672" alt="Screen Shot 2019-05-18 at 6 40 54 PM" src="https://user-images.githubusercontent.com/1577461/57976756-871a0800-799c-11e9-9f06-91111e17bbef.png";> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1577461/57976712-a95f5600-799b-11e9-919b-c56c41707d9c.png"](https://user-images.githubusercontent.com/1577461/57976712-a95f5600-799b-11e9-919b-c56c41707d9c.png"){kind=link}
![https://user-images.githubusercontent.com/1577461/57976723-ce53c900-799b-11e9-8ceb-0340aadc4c06.png"](https://user-images.githubusercontent.com/1577461/57976723-ce53c900-799b-11e9-8ceb-0340aadc4c06.png"){kind=link}
![https://user-images.githubusercontent.com/1577461/57976756-871a0800-799c-11e9-9f06-91111e17bbef.png"](https://user-images.githubusercontent.com/1577461/57976756-871a0800-799c-11e9-9f06-91111e17bbef.png"){kind=link}