jihoonson commented on a change in pull request #7704: SQL: Respect default
timezone for TIME_PARSE and TIME_SHIFT.
URL: https://github.com/apache/incubator-druid/pull/7704#discussion_r285813126
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -5995,7 +5998,7 @@ public void testTimeseriesUsingTimeFloorWithTimeShift()
throws Exception
.setVirtualColumns(
expressionVirtualColumn(
"v0",
-
"timestamp_floor(timestamp_shift(\"__time\",'P1D',-1),'P1M',null,'UTC')",
+
"timestamp_floor(timestamp_shift(\"__time\",'P1D',-1,'UTC'),'P1M',null,'UTC')",
Review comment:
Should we add a test with non UTC timezone as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org
