This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new cb6ec2c SqlOperatorConversion Javadoc fix. (#7713)
cb6ec2c is described below
commit cb6ec2cab856dc0a36bc2ebd480a349ffaaece77
Author: Gian Merlino <[email protected]>
AuthorDate: Mon May 20 21:21:21 2019 -0700
SqlOperatorConversion Javadoc fix. (#7713)
Appears to be a copypasta error; the toDruidFilter method was referred
to aggregations, but it's not handling aggregations.
---
.../apache/druid/sql/calcite/expression/SqlOperatorConversion.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/sql/src/main/java/org/apache/druid/sql/calcite/expression/SqlOperatorConversion.java
b/sql/src/main/java/org/apache/druid/sql/calcite/expression/SqlOperatorConversion.java
index dc85fdb..88d4947 100644
---
a/sql/src/main/java/org/apache/druid/sql/calcite/expression/SqlOperatorConversion.java
+++
b/sql/src/main/java/org/apache/druid/sql/calcite/expression/SqlOperatorConversion.java
@@ -52,10 +52,10 @@ public interface SqlOperatorConversion
DruidExpression toDruidExpression(PlannerContext plannerContext,
RowSignature rowSignature, RexNode rexNode);
/**
- * Returns a Druid Aggregation corresponding to a SQL {@link SqlOperator}
used to filter rows
+ * Returns a Druid filter corresponding to a Calcite {@code RexNode} used as
a filter condition.
*
* @param plannerContext SQL planner context
- * @param querySignature signature of the rows being aggregated and
expression column references
+ * @param querySignature signature of the rows being filtered, and any
expression column references
* @param rexNode filter expression rex node
*
* @return filter, or null if the call cannot be translated
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
