leventov commented on a change in pull request #7738: Fix some problems
reported by PVS-Studio
URL: https://github.com/apache/incubator-druid/pull/7738#discussion_r288095538
##########
File path:
extensions-contrib/kafka-eight-simpleConsumer/src/main/java/org/apache/druid/firehose/kafka/KafkaSimpleConsumer.java
##########
@@ -274,7 +272,7 @@ private long getOffset(boolean earliest) throws
InterruptedException
}
}
- return response != null ? filterAndDecode(response.messageSet(topic,
partitionId), offset) : EMPTY_MSGS;
+ return filterAndDecode(response.messageSet(topic, partitionId), offset);
Review comment:
No, it's impossible. Open this class in IntelliJ - its data flow analysis
identifies that the condition is always true as well.
Related to #7780.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
