gianm commented on issue #7571: Optimize coordinator API to retrieve segments with overshadowed status URL: https://github.com/apache/incubator-druid/issues/7571#issuecomment-496681942 > For me, getting rid of wrapping SegmentWithOvershadowedStatus is the only blocker for 0.15 - I don't want wrapper SegmentWithOvershadowedStatus to slip into internal network API. For 0.15 scope, in the interest of unblocking the release I think the cleanest way to deal with this concern is to keep SegmentWithOvershadowedStatus as a wrapper, but add a custom Jackson serde such that it's serialized as if it were a subclass: all fields on the same level. This is pretty nice, since it means callers that expect a DataSegment can still get one (they'll just ignore the `overshadowed` field). Then we have flexibility to do whatever we want post-0.15 as far as subclass vs. wrapper, since the network API won't need to change. > DataSegment already checks just the id field. Again, please stop thinking about DataSegment as a "data class" with well-defined equality. I was thinking of `allDataEquals` too -- the question being, should it consider a DataSegment instance and a SegmentWithOvershadowedStatus instance as equal or not? It's not clear to me right now which answer (yes or no) would be more useful to most callers. I guess it should be "yes" though since `overshadowed` isn't really "data".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
